Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add Nassim Persian fonts to psammead-styles #676

Merged
merged 6 commits into from
Jun 24, 2019
Merged

Add Nassim Persian fonts to psammead-styles #676

merged 6 commits into from
Jun 24, 2019

Conversation

12
Copy link
Contributor

@12 12 commented Jun 21, 2019

Resolves #675
Overall change: Add Nassim Persian fonts to psammead-styles

Code changes:

  • Add two new exports for Nassim Regular and Nassim Bold
  • Update unit tests
  • Bump versions

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@12 12 added high priority ws-articles Tasks for the WS Articles Team articles-current-epic labels Jun 21, 2019
@12 12 self-assigned this Jun 21, 2019
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@jamesbrumpton
Copy link
Contributor

LGTM

@sareh sareh merged commit 02aeb42 into latest Jun 24, 2019
@sareh sareh deleted the 675_nassim branch June 24, 2019 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Nassim font faces to psammead-styles
4 participants